The sale of access to the president to investors in his digital coin has been assailed by Democrats and even some Republicans as unethical.