The deal has been hailed by President Trump as "a great day" but there are potential pitfalls.